Sonic 2 Clone Driver v2

Discussion in 'Staff Projects' started by Clownacy, Aug 12, 2016.

  1. Spanner

    Spanner The Tool Administrator

    Joined:
    Aug 9, 2007
    Messages:
    2,520
    Cut this shit out, you're still a trialist and you are being watched by the staff whilst you use up your posts to determine if you should get approved later on. Same with the shit posting you and CuckyDev did.
     
  2. Clownacy

    Clownacy Well-Known Member Retired Staff

    Joined:
    Aug 15, 2014
    Messages:
    928
    Ahaha... okay, thanks - I thought I'd tested Sonic 1/2 recently enough that no issues could have sneaked-in since, but it looks like I was wrong. You're right that `Size_of_Mega_PCM_guess` should be `Size_of_DAC_driver_guess`, and that the Settings.asm file should define 'SMPS_SoundTest', ideally setting it to 0. v2.8.0.1 should fix these issues. Thanks for the bug report.

    Sorry, I'm not sure what you're asking. It should be possible to let songs use dual DAC, but this driver doesn't do that. Currently, the second DAC channel can only be used by DAC SFX.
     
    Last edited: Jul 2, 2021
  3. JGamer2151

    JGamer2151 Newcomer Trialist

    Joined:
    Dec 1, 2020
    Messages:
    5
    Alright, so on my Sonic 2 Git disassembly that I was testing on, within Settings.asm I inserted a line for SMPS_SoundTest and set it to 0 (as Clownacy mentioned above). I also changed the "Size_of_Mega_PCM_guess" reference to "Size_of_DAC_driver_guess" and adjusted the equate from $296 to $389 when the error said to increase the value up to the latter value. I then built the ROM, and it worked like a charm! Thanks for the help!
     
    Clownacy likes this.
  4. Mr. Joker 27 Music prod.

    Mr. Joker 27 Music prod. Musician, composer, remixer. Member

    Joined:
    Aug 26, 2016
    Messages:
    217
    Thank you Clownacy, yes, that was I wanted to say, DAC SFX, so I must leave free 1 FM channel to make it works, no?.
    I use MID2SMPS to making my songs, and I wanted to know if is possible make that, thank you sir.
     
    Last edited: Jul 3, 2021
  5. Speems

    Speems Well-Known Member Member

    Joined:
    Mar 14, 2017
    Messages:
    57
    Location:
    Rochester Hills, MI
    That SMPS_SoundTest is indeed part of the errors I got, even when plopping the newest release, although overwriting it with the newer release vanquished those errors. Unfortunately, the SMPS_PauseSoundDriver tidbits don't work for the Sonic 1 Git method at all, even tho that part of the instructions were followed better than the crap in Variables. Also now I get the same Size of DAC guess whatever with the 240 value.
     
  6. Clownacy

    Clownacy Well-Known Member Retired Staff

    Joined:
    Aug 15, 2014
    Messages:
    928
    You only have to leave FM6: the DAC driver uses 1 FM channel for 2 DAC channels.

    Whoops: `SMPS_PauseSoundDriver` and `SMPS_UnpauseSoundDriver` are outdated names for `SMPS_Pause` and `SMPS_Unpause`. I've updated the guide with the proper names, thanks.
     
  7. Speems

    Speems Well-Known Member Member

    Joined:
    Mar 14, 2017
    Messages:
    57
    Location:
    Rochester Hills, MI
    Although that's finally taken care of, I still get an error for SIZE_OF_DAC_DRIVER_GUESS with the 240 value. I've tried so many values but none of them worked. I've seen a value work for S2 Git and tried a similar value method but did not work. And now I'm scared that when that finally gets fixed, there'll be a million errors from the other stuff <:/
     
  8. Clownacy

    Clownacy Well-Known Member Retired Staff

    Joined:
    Aug 15, 2014
    Messages:
    928
    Doesn't the error tell you what value to set it to? I think the error message still uses the old 'Size_of_Mega_PCM_guess' name, but the value itself should still be valid. $389 should work.
     
  9. Speems

    Speems Well-Known Member Member

    Joined:
    Mar 14, 2017
    Messages:
    57
    Location:
    Rochester Hills, MI
    [​IMG]
    Nope, I still get this error. Also, the 393 value (from the driver is this bytes long message) doesn't work either. I even edited that one random file that still uses the Mega PCM thing to instead use the DAC driver text but it doesn't work either.
     
  10. Clownacy

    Clownacy Well-Known Member Retired Staff

    Joined:
    Aug 15, 2014
    Messages:
    928
    The error message says that the value is double-defined. The problem is that both the driver's 'Settings.asm' and the disassembly's 'Constants.asm' files define a variable called 'Size_of_DAC_driver_guess'. The one in 'Constants.asm' should be deleted. I've updated the guide to mention this.
     
    Last edited: Jul 3, 2021
  11. Mr. Joker 27 Music prod.

    Mr. Joker 27 Music prod. Musician, composer, remixer. Member

    Joined:
    Aug 26, 2016
    Messages:
    217
    Thank you, another question. Are you planning to add AMS and FMS?. I know Sonic 1 doesn't supports these effects, just I'm curious.
     
  12. Clownacy

    Clownacy Well-Known Member Retired Staff

    Joined:
    Aug 15, 2014
    Messages:
    928
    Probably not, sorry. I don't know very much about FM, so I don't know how I'd even do that.
     
  13. nineko

    nineko I am the Holy Cat Member

    Joined:
    Mar 24, 2008
    Messages:
    1,853
    Location:
    italy
    I have to wonder, what does your driver do if you attempt to play a DAC sound effect on top of a song which uses 6 FM channels (e.g. Sonic 1's special stage)? Speaking of which, did you fix the 1-UP bug? I'll admit I didn't read the full changelog and I don't plan to ever hack again, but I guess these questions might be useful for other people.
     
  14. Clownacy

    Clownacy Well-Known Member Retired Staff

    Joined:
    Aug 15, 2014
    Messages:
    928
    ...I hadn't thought of that. From the looks of it, the DAC sound effect just won't play if FM6 is enabled. I should be able to do something about that - I've already modified the driver to allow songs to use both FM6 and DAC: when the FM6 track plays a note, DAC is disabled, and when the DAC track plays a sample, FM6 is disabled. That way, songs can use both - just not at the same time. I can make DAC SFX do the same thing. Though, I'd probably need some kind of priority system to prevent new FM6 notes from overriding the DAC SFX.
     
  15. Mr. Joker 27 Music prod.

    Mr. Joker 27 Music prod. Musician, composer, remixer. Member

    Joined:
    Aug 26, 2016
    Messages:
    217
    Thank you very much, this is very good, keep it up, I'm trying to make that DAC SFX, wish me good luck.